Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-2397: use all uppercase characters in QRs #2398

Closed
wants to merge 2 commits into from

Conversation

ajaysehwal
Copy link

@ajaysehwal ajaysehwal commented Sep 7, 2024

Description

Relates to issue: ZEUS-2397

Please enter a description and screenshots, if appropriate, of the work covered in this PR

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@ajaysehwal ajaysehwal changed the title fix : use all uppercase characters in QRs #2397 issue : use all uppercase characters in QRs Sep 7, 2024
@kaloudis kaloudis changed the title #2397 issue : use all uppercase characters in QRs ZEUS-2397: use all uppercase characters in QRs Sep 8, 2024
@kaloudis
Copy link
Contributor

kaloudis commented Sep 8, 2024

I think we want to do the same for BC-ur

@kaloudis
Copy link
Contributor

kaloudis commented Sep 8, 2024

Our BC-ur encoding is actually done under zeus_modules/bc-ur - I haven't checked if it is currently returned in all caps or not at present

@ajaysehwal
Copy link
Author

ok, let me check again.

@kaloudis
Copy link
Contributor

Closing in favor of 17d9edc

@kaloudis kaloudis closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants